Skip to content

Add integration tests and config parser helper#545

Merged
Chucks1093 merged 2 commits into
accesslayerorg:mainfrom
Georgechisom:fix/integration-tests-and-config-parser
Jun 28, 2026
Merged

Add integration tests and config parser helper#545
Chucks1093 merged 2 commits into
accesslayerorg:mainfrom
Georgechisom:fix/integration-tests-and-config-parser

Conversation

@Georgechisom

Copy link
Copy Markdown
Contributor

Add Integration Tests and Config Parser Helper

This PR adds validation integration tests and a safe environment config parser helper to improve validation coverage and startup configuration handling.

Changes

Integration Tests Added:

  • Creator holders endpoint validation for invalid ID formats (non-numeric, float, negative, zero)
  • Webhook registration validation for missing/invalid wallet signatures
  • Wallet activity endpoint validation for malformed Stellar addresses (wrong prefix, too short, invalid characters)

Config Parser Helper:

  • Added parsePositiveInt utility for safely parsing positive integer values from environment variables
  • Returns default value when undefined
  • Throws descriptive startup errors for zero, negative, or non-numeric values
  • Includes comprehensive unit tests

Testing

All new tests verify that validation errors return 400 with descriptive messages before database queries execute.

Closes #537
Closes #539
Closes #536
Closes #535

@drips-wave

drips-wave Bot commented Jun 28, 2026

Copy link
Copy Markdown

@Georgechisom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Georgechisom Georgechisom force-pushed the fix/integration-tests-and-config-parser branch from 38ab1c9 to 1e09bcc Compare June 28, 2026 07:56
@Chucks1093 Chucks1093 merged commit ee1e761 into accesslayerorg:main Jun 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment